UnnecessaryBoxedAssignment: avoid CCE on method reference

Fixes #4157 COPYBARA_INTEGRATE_REVIEW=#4157 from PicnicSupermarket:sschroevers/avoid-CCE-in-UnnecessaryBoxedAssignment 73dc358 PiperOrigin-RevId: 578808258
google · Nov 2, 2023 · bd43f40 · bd43f40
1 parent a63bf9f
commit bd43f40
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessaryBoxedAssignment.java b/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessaryBoxedAssignment.java
@@ -65,7 +65,8 @@ public Description matchVariable(VariableTree tree, VisitorState state) {
   }
 
   private Description matchCommon(ExpressionTree expression, VisitorState state) {
-    if (expression == null || !VALUE_OF_MATCHER.matches(expression, state)) {
+    if (!(expression instanceof MethodInvocationTree)
+        || !VALUE_OF_MATCHER.matches(expression, state)) {
       return Description.NO_MATCH;
     }
     MethodInvocationTree methodInvocationTree = (MethodInvocationTree) expression;

diff --git a/...test/java/com/google/errorprone/bugpatterns/testdata/UnnecessaryBoxedAssignmentCases.java b/...test/java/com/google/errorprone/bugpatterns/testdata/UnnecessaryBoxedAssignmentCases.java
@@ -16,6 +16,8 @@
 
 package com.google.errorprone.bugpatterns.testdata;
 
+import java.util.function.Function;
+
 /**
  * @author awturner@google.com (Andy Turner)
  */
@@ -76,4 +78,8 @@ Integer positive_wrappedAgain(int aInteger) {
     a = Integer.valueOf(aInteger);
     return Integer.valueOf(a);
   }
+
+  void negative_methodReference() {
+    Function<String, Boolean> toBoolean = Boolean::valueOf;
+  }
 }
diff --git a/.../com/google/errorprone/bugpatterns/testdata/UnnecessaryBoxedAssignmentCases_expected.java b/.../com/google/errorprone/bugpatterns/testdata/UnnecessaryBoxedAssignmentCases_expected.java
@@ -16,6 +16,8 @@
 
 package com.google.errorprone.bugpatterns.testdata;
 
+import java.util.function.Function;
+
 /**
  * @author awturner@google.com (Andy Turner)
  */
@@ -76,4 +78,8 @@ Integer positive_wrappedAgain(int aInteger) {
     a = aInteger;
     return a;
   }
+
+  void negative_methodReference() {
+    Function<String, Boolean> toBoolean = Boolean::valueOf;
+  }
 }