Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResultOfMethodCallIgnored] False Positive using AssertJ.isThrownBy #1028

Closed
amarocco opened this issue May 11, 2018 · 2 comments
Closed

[ResultOfMethodCallIgnored] False Positive using AssertJ.isThrownBy #1028

amarocco opened this issue May 11, 2018 · 2 comments

Comments

@amarocco
Copy link

Hello,

I encountered some issue with ErrorProne 2.3.1 and AssertJ 3.9.0
I have a Test that check Exception is well raised using AssertJ's Assertions.assertThatExceptionOfType().isThrownBy() and compilation failed due to errorProne and rule ResultOfMethodCallIgnored

Please look at the following repository for reproduce :
https://github.com/amarocco/error-prone-issue
ronshapiro pushed a commit that referenced this issue May 14, 2018
@nick-someone @ronshapiro
Make CheckReturnValue and friends understand AssertJ's ThrowingCallab…
1f94b86 
…le as a functional interface that is expected to throw an exception.

RELNOTES: CheckReturnValue and similar checks understand AssertJ's ThrowingCallable.

Fixes #1028

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=196333305
@ronshapiro ronshapiro mentioned this issue May 14, 2018
Merged
cushon pushed a commit that referenced this issue May 14, 2018
@nick-someone @cushon
Make CheckReturnValue and friends understand AssertJ's ThrowingCallab…
1f2f82c 
…le as a functional interface that is expected to throw an exception.

RELNOTES: CheckReturnValue and similar checks understand AssertJ's ThrowingCallable.

Fixes #1028

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=196333305
@nick-someone
Copy link
Member

Thanks for the detailed repro! You should see this in the next snapshot release or released version.

@amarocco
Copy link
Author

Ok many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nick-someone @amarocco