Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DoNotMock removed without notice #1246

Closed
dclements opened this issue Mar 15, 2019 · 3 comments · Fixed by #1261
Closed

DoNotMock removed without notice #1246

dclements opened this issue Mar 15, 2019 · 3 comments · Fixed by #1261

Comments

@dclements
Copy link
Member

dclements commented Mar 15, 2019 •
edited

As part of: 66f4d6e#diff-e9fcfd3db76c805219c6849391a9cdcf

DoNotMock and SpyNoMock were removed. But there are no notes indicating that this was the case in any of the release notes since this change.

This means anything that used the public annotation was spontaneously broken when they upgraded.
@kurtisnelson
Copy link

@cushon can we document the replacement?

@eaftan
Copy link
Contributor

eaftan commented Apr 9, 2019

Sorry about this. These were not intended to be external because the enforcement story is more difficult. I will re-opensource @DoNotMock, but I'm less happy with @SpyNoMock, and I'm not excited about people using that one. Do you use both these annotations, or just @DoNotMock?

@kurtisnelson
Copy link

Just DoNotMock. It feels like it should be put over in JSR for anyone to use.

@ronshapiro ronshapiro mentioned this issue Apr 16, 2019
Merged
ronshapiro pushed a commit that referenced this issue Apr 16, 2019
@ronshapiro
Open-source @DoNotMock
b0218c1 
Fixes #1246

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=242727873
ronshapiro pushed a commit that referenced this issue Apr 18, 2019
@ronshapiro
Open-source @DoNotMock
305159d 
Fixes #1246

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=242727873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moe Sync google/error-prone
3 participants
@kurtisnelson @dclements @eaftan