InterruptedExceptionSwallowed.getThrownExceptions incorrectly handles catch blocks #1428
Comments
|
PR is up: #1429 |
Merged
netdpb
pushed a commit
that referenced
this issue
Jan 6, 2020
Fixes external [#1428](#1428). The test is from the linked PR, but the implementation is not. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=287865214
netdpb
pushed a commit
that referenced
this issue
Jan 6, 2020
Fixes external [#1428](#1428). The test is from the linked PR, but the implementation is not. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=287865214
kmclarnon
pushed a commit
to HubSpot/error-prone
that referenced
this issue
Feb 19, 2020
Fixes external [google#1428](google#1428). The test is from the linked PR, but the implementation is not. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=287865214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the problem / feature request:
InterruptedExceptionSwallowed.getThrownExceptions incorrectly handles catch blocks when there are multiple catch trees. As written, the function assumes each catch is capable of handling errors thrown by previous catch blocks, which is not the case.
Feature requests: what underlying problem are you trying to solve with this feature?
The bug checker should take into account how TryTrees are executed in java.
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
I will push a failing test shortly.
What version of Error Prone are you using?
df4cdef
Have you found anything relevant by searching the web?
No.
The text was updated successfully, but these errors were encountered: