Severity level error is still listed in the documentation for the checks that were recently demoted to warnings

[davido]

In 230ad26
the two checks were demoted to severity level warning, but it seems that the documentation was missed to be adapted: [1], [2].

[1] https://errorprone.info/bugpattern/ExtendsAutoValue
[2] https://errorprone.info/bugpattern/RefersToDaggerCodegen

[eaftan]

Thanks for the report. It looks like that commit disabled those checks instead of making them warnings. @cushon, was that intentional?

[cushon]

I forget whether I intended to make them warnings and messed up the description, or the other way around. But disabling them seems OK to me.

The issue with the docs here is that the CI used to automatically push updated docs to the gh-pages branch, and that seems to have rotted.

[davido]

But disabling them seems OK to me.

My understanding is that the intention was to only demote the checks to warning severity for now, until the EP community migrated off Java 8 and revert to the error severity later.

As we know Java 8/Java 11 cross compilation is somehow convoluted in Bazel and produces hard to understand and fix failures, e.g. [1],[2].

Given that Bazel only considers checks with error severity by default it would be totally sufficient to demote the severity level (including the documentation) and not to disable the checks.

[1] bazelbuild/rules_closure#483
[2] bazelbuild/rules_kotlin#321