Skip to content

Commit

Permalink
Demote a couple of checks that rely on @generated annotations to warn…
Browse files Browse the repository at this point in the history
…ings

to avoid break builds that don't have an `@Generated` annotation
available, see discussion in:

#1348

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=312115507
  • Loading branch information
cushon authored and cgdecker committed May 20, 2020
1 parent 937b3d2 commit 230ad26
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,6 @@ public static ScannerSupplier errorChecks() {
EqualsNaN.class,
EqualsReference.class,
EqualsWrongThing.class,
ExtendsAutoValue.class,
ForOverrideChecker.class,
FormatString.class,
FormatStringAnnotationChecker.class,
Expand Down Expand Up @@ -619,7 +618,6 @@ public static ScannerSupplier errorChecks() {
RandomCast.class,
RandomModInteger.class,
RectIntersectReturnValueIgnored.class,
RefersToDaggerCodegen.class,
RestrictedApiChecker.class,
ReturnValueIgnored.class,
SelfAssignment.class,
Expand Down Expand Up @@ -874,6 +872,7 @@ public static ScannerSupplier errorChecks() {
EmptyTopLevelDeclaration.class,
EqualsBrokenForNull.class,
ExpectedExceptionChecker.class,
ExtendsAutoValue.class,

This comment has been minimized.

Copy link
@davido

davido Jul 6, 2020

Contributor

Same here.

FieldCanBeFinal.class,
FieldCanBeLocal.class,
FieldMissingNullable.class,
Expand Down Expand Up @@ -917,6 +916,7 @@ public static ScannerSupplier errorChecks() {
RedundantCondition.class,
RedundantOverride.class,
RedundantThrows.class,
RefersToDaggerCodegen.class,

This comment has been minimized.

Copy link
@davido

davido Jul 6, 2020

Contributor

This didn't change the documentation, it is still listed with severity error: [1].

I wrote this issue: #1704.

[1] https://errorprone.info/bugpattern/RefersToDaggerCodegen

RemoveUnusedImports.class,
ScopeOnModule.class,
ScopeOrQualifierAnnotationRetention.class,
Expand Down

0 comments on commit 230ad26

Please sign in to comment.