You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if this is a bug or feature request, fill the form below as best as you can.
Description of the problem / feature request:
FieldCanBeStatic is failing because of the presence of a record.
[ERROR] error-prone version: 2.6.0
[ERROR] BugPattern: FieldCanBeStatic
[ERROR] Stack Trace:
[ERROR] java.lang.AssertionError: Unexpected type kind RECORD
[ERROR] at com.google.errorprone.bugpatterns.threadsafety.ThreadSafety$ThreadSafeTypeVisitor.visitType(ThreadSafety.java:565)
[ERROR] at com.google.errorprone.bugpatterns.threadsafety.ThreadSafety$ThreadSafeTypeVisitor.visitType(ThreadSafety.java:499)
[ERROR] at jdk.compiler/com.sun.tools.javac.code.Types$DefaultTypeVisitor.visitClassType(Types.java:4903)
[ERROR] at jdk.compiler/com.sun.tools.javac.code.Type$ClassType.accept(Type.java:1010)
[ERROR] at com.google.errorprone.bugpatterns.threadsafety.ThreadSafety.isThreadSafeType(ThreadSafety.java:495)
[ERROR] at com.google.errorprone.bugpatterns.FieldCanBeStatic.isTypeKnownImmutable(FieldCanBeStatic.java:292)
[ERROR] at com.google.errorprone.bugpatterns.FieldCanBeStatic.matchVariable(FieldCanBeStatic.java:190)
[ERROR] at com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:450)
[ERROR] at com.google.errorprone.scanner.ErrorProneScanner.visitVariable(ErrorProneScanner.java:885)
[ERROR] at com.google.errorprone.scanner.ErrorProneScanner.visitVariable(ErrorProneScanner.java:151)
[ERROR] at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCVariableDecl.accept(JCTree.java:1001)
[ERROR] at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:86)
[ERROR] at com.google.errorprone.scanner.Scanner.scan(Scanner.java:74)
[ERROR] at com.google.errorprone.scanner.Scanner.scan(Scanner.java:48)
[ERROR] at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:94)
[ERROR] at jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:109)
[ERROR] at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:117)
[ERROR] at jdk.compiler/com.sun.source.util.TreeScanner.visitClass(TreeScanner.java:193)
[ERROR] at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:549)
[ERROR] at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:151)
[ERROR] at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:832)
[ERROR] at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:86)
[ERROR] at com.google.errorprone.scanner.Scanner.scan(Scanner.java:74)
[ERROR] at com.google.errorprone.scanner.Scanner.scan(Scanner.java:48)
[ERROR] at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:94)
[ERROR] at jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:109)
[ERROR] at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:117)
[ERROR] at jdk.compiler/com.sun.source.util.TreeScanner.visitClass(TreeScanner.java:193)
[ERROR] at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:549)
[ERROR] at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:151)
[ERROR] at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:832)
[ERROR] at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:86)
[ERROR] at com.google.errorprone.scanner.Scanner.scan(Scanner.java:74)
[ERROR] at com.google.errorprone.scanner.Scanner.scan(Scanner.java:48)
[ERROR] at jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:109)
[ERROR] at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:117)
[ERROR] at jdk.compiler/com.sun.source.util.TreeScanner.visitCompilationUnit(TreeScanner.java:148)
[ERROR] at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:561)
[ERROR] at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:151)
[ERROR] at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:603)
[ERROR] at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:60)
[ERROR] at com.google.errorprone.scanner.Scanner.scan(Scanner.java:58)
[ERROR] at com.google.errorprone.scanner.ErrorProneScannerTransformer.apply(ErrorProneScannerTransformer.java:43)
[ERROR] at com.google.errorprone.ErrorProneAnalyzer.finished(ErrorProneAnalyzer.java:152)
[ERROR] at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:132)
[ERROR] at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1421)
[ERROR] at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1368)
[ERROR] at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:960)
[ERROR] at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:317)
[ERROR] at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:176)
[ERROR] at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:64)
[ERROR] at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:50)
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
This appears to be enough. The suppression is needed because this example also causes a different problem in another checker (issue #2323).
packageexample;
@SuppressWarnings("PrivateConstructorForUtilityClass")
publicfinalclassExampleClass
{
public record OtherRecord(Stringvalue) { }
public record SomeRecord(OtherRecordvalue)
{
publicstaticSomeRecordfromValue(finalOtherRecordvalue)
{
returnnewSomeRecord(value);
}
}
privateExampleClass() {
}
}
What version of Error Prone are you using?
2.6.0
The text was updated successfully, but these errors were encountered:
Description of the problem / feature request:
FieldCanBeStatic
is failing because of the presence of a record.Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
This appears to be enough. The suppression is needed because this example also causes a different problem in another checker (issue #2323).
What version of Error Prone are you using?
2.6.0
The text was updated successfully, but these errors were encountered: