Remove unused dependency #1408
Closed
Remove unused dependency #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpovirk
pushed a commit
that referenced
this pull request
Nov 14, 2019
Fixes #1408 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=280307365
Merged
cpovirk
pushed a commit
that referenced
this pull request
Nov 14, 2019
Fixes #1408 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=280307365
kmclarnon
pushed a commit
to HubSpot/error-prone
that referenced
this pull request
Feb 19, 2020
Fixes google#1408 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=280307365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I noticed that dependency
jcip-annotationsis declared in thepomof the core module. However, this dependency is not used. Therefore, it makes sense to remove it in order to make the core of the library slimmer, and the Maven dependency tree less complex and easier to maintain.