ConstructorInvokesOverridable: fix some false positives #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not match methods of anonymous classes. Those methods can't be overriden because those classes can't be extended. Do not match methods of certain enum classes. It is not possible to override the methods of an enum class except in the (anonymous) class bodies of its enum constants. If all the enum constants lack class bodies, then the enum class's methods can't be overridden. Fix cases where the bug pattern would become confused about the receiver of unqualified or this-qualified method invocations, and where it would wrongly conclude that the method belonged to the instance under construction and issue a warning. Support @SuppressWarnings("ConstructorInvokesOverridable") on more elements. Fixes google#656.
Stephan202
approved these changes
Dec 16, 2019
Merged
kluever
pushed a commit
that referenced
this pull request
Dec 18, 2019
Do not match methods of anonymous classes. Those methods can't be overriden because those classes can't be extended. Do not match methods of certain enum classes. It is not possible to override the methods of an enum class except in the (anonymous) class bodies of its enum constants. If all the enum constants lack class bodies, then the enum class's methods can't be overridden. Fix cases where the bug pattern would become confused about the receiver of unqualified or this-qualified method invocations, and where it would wrongly conclude that the method belonged to the instance under construction and issue a warning. Support @SuppressWarnings("ConstructorInvokesOverridable") on more Fixes #1449 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=286077091
kluever
pushed a commit
that referenced
this pull request
Dec 18, 2019
Do not match methods of anonymous classes. Those methods can't be overriden because those classes can't be extended. Do not match methods of certain enum classes. It is not possible to override the methods of an enum class except in the (anonymous) class bodies of its enum constants. If all the enum constants lack class bodies, then the enum class's methods can't be overridden. Fix cases where the bug pattern would become confused about the receiver of unqualified or this-qualified method invocations, and where it would wrongly conclude that the method belonged to the instance under construction and issue a warning. Support @SuppressWarnings("ConstructorInvokesOverridable") on more Fixes #1449 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=286077091
|
Thanks for the fix! |
kmclarnon
pushed a commit
to HubSpot/error-prone
that referenced
this pull request
Feb 19, 2020
Do not match methods of anonymous classes. Those methods can't be overriden because those classes can't be extended. Do not match methods of certain enum classes. It is not possible to override the methods of an enum class except in the (anonymous) class bodies of its enum constants. If all the enum constants lack class bodies, then the enum class's methods can't be overridden. Fix cases where the bug pattern would become confused about the receiver of unqualified or this-qualified method invocations, and where it would wrongly conclude that the method belonged to the instance under construction and issue a warning. Support @SuppressWarnings("ConstructorInvokesOverridable") on more Fixes google#1449 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=286077091
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not match methods of anonymous classes. Those methods can't be
overriden because those classes can't be extended.
Do not match methods of certain enum classes. It is not possible to
override the methods of an enum class except in the (anonymous) class
bodies of its enum constants. If all the enum constants lack class
bodies, then the enum class's methods can't be overridden.
Fix cases where the bug pattern would become confused about the receiver
of unqualified or this-qualified method invocations, and where it would
wrongly conclude that the method belonged to the instance under
construction and issue a warning.
Support
@SuppressWarnings("ConstructorInvokesOverridable")on moreelements. Fixes #656.