Fix #1454: Matchers.booleanConstant(true) doesn't match Boolean.FALSE #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kluever
pushed a commit
that referenced
this pull request
Dec 18, 2019
Boolean.FALSE Fixes #1455 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=286070502
kluever
pushed a commit
that referenced
this pull request
Dec 18, 2019
Boolean.FALSE Fixes #1455 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=286070502
|
This was a nice catch. Thanks for the contribution! |
|
Thanks for the review and merge @eaftan :-) |
kmclarnon
pushed a commit
to HubSpot/error-prone
that referenced
this pull request
Feb 19, 2020
Boolean.FALSE Fixes google#1455 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=286070502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.