MOE Sync 2020-01-08 #1467
Merged
MOE Sync 2020-01-08 #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
follow-up to c6c372c ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288509125
… endpos for @see. Fixes external #1444 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=288656035
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
Make visit methods more consistent
follow-up to c6c372c
a6b8826
MissingSummary: don't fail in the case that javac fails to provide an endpos for @see.
Fixes external #1444
d7e5866