Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOE Sync 2020-01-09 #1468

Closed
wants to merge 3 commits into from
Closed

MOE Sync 2020-01-09 #1468

wants to merge 3 commits into from

Conversation

netdpb
Copy link
Member

@netdpb netdpb commented Jan 9, 2020

This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.

Commits:

Make visit methods more consistent

follow-up to c6c372c

8de6806


MissingSummary: don't fail in the case that javac fails to provide an endpos for @see.

Fixes #1444

7b92190


Improve documentation for FormatStringAnnotation fix

b4652bd

cushon and others added 3 commits January 9, 2020 10:20
follow-up to c6c372c

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=288509125
… endpos for @see.

Fixes #1444

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=288656035
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=288713584
@netdpb
Copy link
Member Author

netdpb commented Jan 9, 2020

Oops. Didn't merge yesterday's PR. Let me do that and try again.

@netdpb netdpb closed this Jan 9, 2020
@netdpb netdpb deleted the sync-master-2020/01/09 branch January 9, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MissingSummary triggers IllegalArgumentException
4 participants