MOE Sync 2020-01-13 #1475
Merged
MOE Sync 2020-01-13 #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I always forget that this method takes the VisitorState partly for the TreePath. It's a little ironically error-prone... ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=289103677
Fixes external #1462 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=289114572
…pare if the arguments undergo a lossy widening conversion ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=289150261
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=289399329
I found some odd cases where @SuppressWarnings doesn't suppress as you would expect. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=289399783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
StronglyTypeTime: qualify the type correctly.
I always forget that this method takes the VisitorState partly for the TreePath. It's a little ironically error-prone...
7ea13b9
MisusedDayOfYear: flag date formats with D where M is also used.
Fixes external #1462
7ed6f71
LossyPrimitiveCompare: disallow usage of Float.compare and Double.compare if the arguments undergo a lossy widening conversion
a68919e
ExtendsAutoValueTest: run the AutoValue processor at test time.
8f77221
LockScanner: check suppressions more.
I found some odd cases where @SuppressWarnings doesn't suppress as you would expect.
b205fe3