-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SystemOut checker #1534
Add SystemOut checker #1534
Conversation
Is the idea for this to be disabled by default, but make it available so projects where using |
I would personally always enable it, and The reason I put it in the disabled-by-default list was mostly that |
I DI System.out and System.err from main but otherwise pass around Print* classes or use a proper logging framework. |
Thanks for the reminder about I think that requiring I think this makes sense to make available as an opt-in / disabled-by-default check. |
This checker checks for uses of System.out and System.err as possible logs used for debugging purpose.
I rebased the branch, in case it can unblock copybara. |
This checker checks for uses of System.out and System.err as
possible logs used for debugging purpose.
Inspired by Policeman's Forbidden API Checker's
jdk-system-out
checks.See also #1211