Fix NPE in MutablePublicArray check #1586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MutablePublicArray check throws a NPE when examining an array that's initialized during a static init block. Add a test case and null checks.
|
I'm a fairly inexperienced Java developer and it's not obvious if there's a better fix for the new test, but the PR as-is passes all the existing test cases in addition to the newly added one. |
cushon
reviewed
May 12, 2020
| @@ -67,7 +67,7 @@ private static boolean nonEmptyArrayMatcher(VariableTree arrayExpression, Visito | |||
| return false; | |||
| } | |||
| JCNewArray newArray = (JCNewArray) arrayExpression.getInitializer(); | |||
| if (!newArray.getDimensions().isEmpty()) { | |||
There was a problem hiding this comment.
Thanks for the fix. I suggest just doing the null-check here, instead of having to repeat it below:
if (newArray == null) {
return false;
}
(I can make that edit when importing the PR, this is just an FYI.)
Merged
kluever
pushed a commit
that referenced
this pull request
May 13, 2020
The MutablePublicArray check throws a NPE when examining an array that's initialized during a static init block. Add a test case Fixes #1586 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311230609
kluever
pushed a commit
that referenced
this pull request
May 13, 2020
The MutablePublicArray check throws a NPE when examining an array that's initialized during a static init block. Add a test case Fixes #1586 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311230609
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MutablePublicArray check throws a NPE when examining
an array that's initialized during a static init block. Add a test case
and null checks.