Don't warn if methods annotated @PreDestroy / @PostConstruct are unused #1705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods annotated with
@PreDestroy
and@PostConstruct
are managed by Java EE and the Java spec describes "The method [...] MAY be public, protected, package private or private". So I'd argue there shouldn't be are warning for private methods annotated with either of those annotations.Those two annotations were also mentioned in #1235
See:
https://docs.oracle.com/javase/8/docs/api/javax/annotation/PostConstruct.html
https://docs.oracle.com/javase/8/docs/api/javax/annotation/PreDestroy.html