Avoid NPE in SameNameButDifferent
#1987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fully skip trees for which the source code is unavailable. While there, also fix what appears to be a typo: "Buiilder" -> "Builder".
Stephan202
commented
Dec 6, 2020
Comment on lines
-110
to
+113
| if (state.getEndPosition(tree) != Position.NOPOS) { | ||
| treePaths.add(getCurrentPath()); | ||
| } | ||
| treePaths.add(getCurrentPath()); |
There was a problem hiding this comment.
Dropped the if-statement because treeSource != null implies state.getEndPosition(tree) != Position.NOPOS.
| @@ -96,20 +96,21 @@ private boolean shouldIgnore() { | |||
|
|
|||
| private void handle(Tree tree) { | |||
| if (tree instanceof IdentifierTree | |||
| && ((IdentifierTree) tree).getName().contentEquals("Buiilder")) { | |||
| && ((IdentifierTree) tree).getName().contentEquals("Builder")) { | |||
There was a problem hiding this comment.
I assume this is what was meant.
cushon
approved these changes
Dec 15, 2020
cushon
approved these changes
Dec 15, 2020
stevie400
pushed a commit
to HubSpot/error-prone
that referenced
this pull request
Jan 15, 2021
With this change the check fully skips trees for which the source code is unavailable.
While there, also fix what appears to be a typo: "Buiilder" -> "Builder".
Stack trace of the error avoided by this change:
```
[ERROR] /path/to/some/Class.java:[1,1] An unhandled exception was thrown by the Error Prone static analysis plugin.
Please report this at https://github.com/google/error-prone/issues/new and include the following:
error-prone version: 2.4.1-SNAPSHOT
BugPattern: SameNameButDifferent
Stack Trace:
java.lang.NullPointerException
at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:877)
at com.google.common.collect.StandardTable.put(StandardTable.java:145)
at com.google.common.collect.HashBasedTable.put(HashBasedTable.java:51)
at com.google.errorprone.bugpatterns.SameNameButDifferent$1.handle(SameNameButDifferent.java:108)
at com.google.errorprone.bugpatterns.SameNameButDifferent$1.visitMemberSelect(SameNameButDifferent.java:66)
at com.google.errorprone.bugpatterns.SameNameButDifferent$1.visitMemberSelect(SameNameButDifferent.java:62)
... snip ...
```
Fixes google#1987
COPYBARA_INTEGRATE_REVIEW=google#1987 from PicnicSupermarket:bugfix/SameNameButDifferent-NPE 3287283
PiperOrigin-RevId: 347736857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the check fully skips trees for which the source code is unavailable.
While there, also fix what appears to be a typo: "Buiilder" -> "Builder".
Stack trace of the error avoided by this change: