Handle SuggestedFixes#qualifyStaticImport method declaration clashes
#2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a class declares a method `m` then statically importing another method `m` does not have the desired effect.
Stephan202
commented
Dec 13, 2020
| } | ||
|
|
||
| @Test | ||
| public void qualifyStaticImport_whenMethodNamesClash_usesQualifiedName() { |
There was a problem hiding this comment.
Prior to these changes this test would fail, because verifyNotNull is declared but not referenced.
cushon
approved these changes
Dec 15, 2020
Stephan202
deleted the
bugfix/SuggestedFixes-qualifyStaticImport-check-method-declarations
branch
stevie400
pushed a commit
to HubSpot/error-prone
that referenced
this pull request
Jan 15, 2021
If a class declares a method `m` then statically importing another method `m` does not have the desired effect. Fixes google#2009 COPYBARA_INTEGRATE_REVIEW=google#2009 from PicnicSupermarket:bugfix/SuggestedFixes-qualifyStaticImport-check-method-declarations 96279a5 PiperOrigin-RevId: 347673530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a class declares a method
mthen statically importing another methodmdoes not have the desired effect.