MissingCasesInEnumSwitch handles case labels with multiple expressions #2026
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MissingCasesInEnumSwitch
does not correctly handle multi-expression case labels in switch expressions. It uses the deprecatedCaseTree#getExpression
method, which only returns the first expression in the case label.A simple example is shown below:
This code will produce the following error:
This PR updates
MissingCasesInEnumSwitch
to instead use the non-deprecatedCaseTree#getExpressions
method, which returns all expressions in the case label.Unfortunately this requires using reflection because the
CaseTree#getExpressions
method was not added until Java 12.