Handle diagnostics without source #2064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, compiler diagnostics may not have an associated source, and for testing whether suggested fixes compile these should be treated as originating from the same compilation unit of the suggested fix.
…ixes.java Co-authored-by: Stephan Schroevers <stephan202@gmail.com>
cushon
approved these changes
Jan 7, 2021
|
@cushon Is there anything I need to do to trigger the merge here? From other PRs it looks like |
I have everything I need to finish the merge. I'm just waiting for another human to look at it, and then the bot will merge it. Thanks for the fix! |
|
Thanks @cushon ! |
stevie400
pushed a commit
to HubSpot/error-prone
that referenced
this pull request
Jan 15, 2021
In some cases, compiler diagnostics may not have an associated source, and for testing whether suggested fixes compile these should be treated as originating from the same compilation unit of the suggested fix. Fixes google#1873 Fixes google#2064 COPYBARA_INTEGRATE_REVIEW=google#2064 from schlosna:ds/1873-SuggestedFixes-NPE ddd042b PiperOrigin-RevId: 350812718
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, compiler diagnostics may not have an associated source,
and for testing whether suggested fixes compile these should be treated
as originating from the same compilation unit of the suggested fix.
Fixes #1873