-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refaster: fix expression matching in absence of additional syntactic context #2805
base: master
Are you sure you want to change the base?
Refaster: fix expression matching in absence of additional syntactic context #2805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach was tested extensively in the context of @rickie's Msc thesis 👍
3b86713
to
a1fd29b
Compare
Rebased and added a commit to be compatible with the latest changes. |
a1fd29b
to
e3d86cf
Compare
e3d86cf
to
29b528a
Compare
29b528a
to
e5a7be0
Compare
Rebased and resolved conflict. This still is a nice improvement :). |
Some context, since one might ask "why would you want to define such a In case there are questions about this, I'm sure that @rickie will gladly answer them. ;) |
79366f8
to
8bab354
Compare
8bab354
to
d334c28
Compare
Rebased. |
d334c28
to
fdc96e3
Compare
fdc96e3
to
d3d6b1d
Compare
Rebased. @cushon I'm curious to hear your thoughts on this PR. Do you have some time to look into this? This is one of the PRs that we worked on in the context of my thesis as @Stephan202 mentioned in his previous comment. |
@BeforeTemplate
implementations of the formreturn someParam;
are validconstructs. With these changes such templates behave as expected, such that
someParam
only matches expressions of the appropriate type, not references tothe type itself.