Improve LockOnNonEnclosingClassLiteral documentation
#3986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cushon
approved these changes
Jun 21, 2023
cushon
approved these changes
Jun 27, 2023
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
I noticed that the code is not properly rendered in the markdown: https://errorprone.info/bugpattern/LockOnNonEnclosingClassLiteral. While working on this, I improved and re-flowed the text. Let me know if I changed too much and should limit it to the incorrect rendering of the code examples. Fixes #3986 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3986 from PicnicSupermarket:rossendrijver/LockOnNonEnclosingClassLiteral-markdown 6bb5c29 PiperOrigin-RevId: 543859096
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
I noticed that the code is not properly rendered in the markdown: https://errorprone.info/bugpattern/LockOnNonEnclosingClassLiteral. While working on this, I improved and re-flowed the text. Let me know if I changed too much and should limit it to the incorrect rendering of the code examples. Fixes #3986 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3986 from PicnicSupermarket:rossendrijver/LockOnNonEnclosingClassLiteral-markdown 6bb5c29 PiperOrigin-RevId: 543859096
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
I noticed that the code is not properly rendered in the markdown: https://errorprone.info/bugpattern/LockOnNonEnclosingClassLiteral. While working on this, I improved and re-flowed the text. Let me know if I changed too much and should limit it to the incorrect rendering of the code examples. Fixes #3986 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3986 from PicnicSupermarket:rossendrijver/LockOnNonEnclosingClassLiteral-markdown 6bb5c29 PiperOrigin-RevId: 543859096
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the code is not properly rendered in the markdown: https://errorprone.info/bugpattern/LockOnNonEnclosingClassLiteral.
While working on this, I improved and re-flowed the text.
Let me know if I changed too much and should limit it to the incorrect rendering of the code examples.