Replace ZoneId.of("UTC") with ZoneOffset.UTC #3988
Conversation
| "TestClass.java", | ||
| "import java.time.ZoneId;", | ||
| "public class TestClass {", | ||
| " private static final ZoneId UTC = ZoneId.of(\"utc\");", |
There was a problem hiding this comment.
Not a huge deal, but http://errorprone.info/bugpattern/InvalidZoneId should prevent this from compiling in the first place :-)
| @@ -57,7 +57,7 @@ public final class ZoneIdOfZ extends BugChecker implements MethodInvocationTreeM | |||
| public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState state) { | |||
| if (ZONE_ID_OF.matches(tree, state)) { | |||
| String zone = constValue(tree.getArguments().get(0), String.class); | |||
| if (zone != null && zone.equals("Z")) { | |||
| if (zone != null && (zone.equals("Z") || zone.equals("UTC"))) { | |||
There was a problem hiding this comment.
So technically, ZoneId.of("UTC") is not equal to ZoneOffset.UTC. They have different values for getId(), (the former is "Z" and the latter is "UTC" I believe)...whether this matters in practice, I'm not sure.
Any ideas?
There was a problem hiding this comment.
Ah I did not realize that, thanks for pointing this out. Let me know if you'd prefer not to merge this because of this potentially breaking change.
There was a problem hiding this comment.
Yea let's revert this to be on the safe side, especially since this is enabled as an error, not just a warning.
This PR updates the
ZoneIdOfZcheck to also replaceZoneId.of("UTC").