Support @SuppressWarnings("all")
#4076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks that are suppressed using `@SuppressWarnings("CheckName")` are
now also suppressed by `@SuppressWarnings("all")`, as emitted by
libraries such as Lombok and Immutables.
Checks that are unsuppressible, or can only be suppressed by a custom
annotation are _not_ suppressed by `@SuppressWarnings("all")`.
While there: improve the deprecated `BugChecker#isSuppressed(Tree)` and
`BugChecker#isSuppressed(Symbol)` methods to respect
`BugChecker#supportsSuppressWarnings()`.
Stephan202
commented
Sep 10, 2023
Comment on lines
272
to
279
| private boolean isSuppressed(SuppressWarnings suppression) { | ||
| return suppression != null | ||
| && !Collections.disjoint(Arrays.asList(suppression.value()), allNames()); | ||
| if (suppression == null || !supportsSuppressWarnings()) { | ||
| return false; | ||
| } | ||
|
|
||
| List<String> suppressions = Arrays.asList(suppression.value()); | ||
| return suppressions.contains("all") || !Collections.disjoint(suppressions, allNames()); | ||
| } |
There was a problem hiding this comment.
This method is effectively deprecated, since it's only called by deprecated code; the first test below covers it.
Comment on lines
+35
to
+63
| @Test | ||
| public void isSuppressed_withoutVisitorState() { | ||
| CompilationTestHelper.newInstance(LegacySuppressionCheck.class, getClass()) | ||
| .addSourceLines( | ||
| "A.java", | ||
| "class A {", | ||
| " void m() {", | ||
| " // BUG: Diagnostic contains: []", | ||
| " int unsuppressed;", | ||
| " // BUG: Diagnostic contains: []", | ||
| " @SuppressWarnings(\"foo\") int unrelatedSuppression;", | ||
| " // BUG: Diagnostic contains: [Suppressible]", | ||
| " @SuppressWarnings(\"Suppressible\") int suppressed;", | ||
| " // BUG: Diagnostic contains: [Suppressible]", | ||
| " @SuppressWarnings(\"Alternative\") int suppressedWithAlternativeName;", | ||
| " // BUG: Diagnostic contains: [Suppressible]", | ||
| " @SuppressWarnings(\"all\") int allSuppressed;", | ||
| " // BUG: Diagnostic contains: [Suppressible]", | ||
| " @SuppressWarnings({\"foo\", \"Suppressible\"}) int alsoSuppressed;", | ||
| " // BUG: Diagnostic contains: [Suppressible]", | ||
| " @SuppressWarnings({\"all\", \"foo\"}) int redundantlySuppressed;", | ||
| " // BUG: Diagnostic contains: [Suppressible]", | ||
| " @SuppressWarnings({\"all\", \"OnlySuppressedInsideDeprecatedCode\"}) int ineffectiveSuppression;", | ||
| " // BUG: Diagnostic contains: []", | ||
| " @Deprecated int unuspportedSuppression;", | ||
| " }", | ||
| "}") | ||
| .doTest(); | ||
| } |
There was a problem hiding this comment.
The final test case here shows why the code under test is deprecated: the suppressionAnnotations = Deprecated.class directive isn't respected.
This was referenced Sep 10, 2023
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
Checks that are suppressed using `@SuppressWarnings("CheckName")` are
now also suppressed by `@SuppressWarnings("all")`, as emitted by
libraries such as Lombok and Immutables.
Checks that are unsuppressible, or can only be suppressed by a custom
annotation are _not_ suppressed by `@SuppressWarnings("all")`.
While there: improve the deprecated `BugChecker#isSuppressed(Tree)` and
`BugChecker#isSuppressed(Symbol)` methods to respect
`BugChecker#supportsSuppressWarnings()`.
Resolves #4065.
Fixes #4076
FUTURE_COPYBARA_INTEGRATE_REVIEW=#4076 from PicnicSupermarket:sschroevers/suppress-warnings-all 1b8f663
PiperOrigin-RevId: 565426144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks that are suppressed using
@SuppressWarnings("CheckName")arenow also suppressed by
@SuppressWarnings("all"), as emitted bylibraries such as Lombok and Immutables.
Checks that are unsuppressible, or can only be suppressed by a custom
annotation are not suppressed by
@SuppressWarnings("all").While there: improve the deprecated
BugChecker#isSuppressed(Tree)andBugChecker#isSuppressed(Symbol)methods to respectBugChecker#supportsSuppressWarnings().Resolves #4065.