Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DefaultCharset.java #4114

Closed
wants to merge 3 commits into from
Closed

Update DefaultCharset.java #4114

wants to merge 3 commits into from

Conversation

delanym
Copy link
Contributor

@delanym delanym commented Sep 24, 2023

Prefer (?, Charset) to (?, String) constructor
Copy link
Collaborator

@cushon cushon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks for the PR.

The tests are currently failing because they are assertion on the old version of the refactoring that included .name(), can you update them?

copybara-service bot pushed a commit that referenced this pull request Sep 25, 2023
Prefer (?, Charset) to (?, String) constructor

Such as https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/Scanner.html#%3Cinit%3E(java.io.File,java.nio.charset.Charset)

Fixes #4114

FUTURE_COPYBARA_INTEGRATE_REVIEW=#4114 from delanym:patch-1 18dbdc4
PiperOrigin-RevId: 568045902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants