-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: module name → com.google.errorprone.annotations
#4317
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ | |
* limitations under the License. | ||
*/ | ||
|
||
open module com.google.errorprone.annotation { | ||
open module com.google.errorprone.annotations { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Module fix. One million palms on face. |
||
requires java.compiler; | ||
|
||
exports com.google.errorprone.annotations; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -150,10 +150,9 @@ | |
<bnd><![CDATA[ | ||
Bundle-SymbolicName: com.google.$<replacestring;$<replacestring;${project.artifactId};^error_prone;errorprone>;_;.> | ||
Automatic-Module-Name: $<Bundle-SymbolicName> | ||
-exportcontents: com.google.errorprone*,!META-INF.* | ||
-exportcontents: com.google.errorprone* | ||
-noextraheaders: true | ||
-removeheaders: Private-Package | ||
-fixupmessages: ^Classes found in the wrong directory: .* | ||
Comment on lines
151
to
-156
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice silver lining: the OSGI configuration at the top level is now completely restored to what it was before. Only the |
||
]]></bnd> | ||
</configuration> | ||
</execution> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix: OSGI plugin now has a dedicated run within the child project, and suppresses the parent run with
<phase>none</phase>
.