Don't rewrite equal
to ==
for floating-point values.
#4401
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't rewrite
equal
to==
for floating-point values.Objects.equal(a_double, another_double)
anda_double == another_double
have different semantics (different result when both compared values are NaN). This is especially relevant when implementingequals
methods.Fixes #4392
Fixes #4394
FUTURE_COPYBARA_INTEGRATE_REVIEW=#4394 from findepi:findepi/double-compare 603b9c6