Multi-Release jar experiments #4521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
reviewed
Aug 11, 2024
| // We could use buffer.toName(Names), but we want a string anyways and this | ||
| // avoids plumbing a Context or instances of Names through. | ||
| // Names always uses UTF-8 internally. | ||
| return new String(Arrays.copyOf(buffer.elems, buffer.length), UTF_8); |
There was a problem hiding this comment.
I recall once running a benchmark, on the basis of which I concluded that the JVM may be smart enough to conclude that in a scenario such as this one, the String constructor doesn't need to make a defensive copy of the provided array, as it'll hold the only remaining reference. Still, perhaps it's nicer to instead do:
Suggested change
| return new String(Arrays.copyOf(buffer.elems, buffer.length), UTF_8); | |
| return new String(buffer.elems, 0, buffer.length, UTF_8); |
(And likewise for the Java 24 variant below.)
There was a problem hiding this comment.
Thanks, good point. I had separately been considering refactoring this to pass through a VisitorState to these methods instead of Type, which would allow using buffer.toName(Names) as the comment here notes. I'll take a look at finishing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.