Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moe sync #642

Closed
wants to merge 17 commits into from
Closed

Moe sync #642

wants to merge 17 commits into from

Commits on Jun 14, 2017

  1. Fix false positives from FunctionalInterfaceClash. 

    If you have an inheritance chain that expands the visibility of an overridden
method, the FunctionalInterfaceClash checker may consider consider those to be
separate methods rather than overrides of the same method, causing a false
positive.

RELNOTES: None

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157045905
    @ronshapiro
    eaftan authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    35b4442 View commit details
    Browse the repository at this point in the history

  2. Automated rollback of 8a87d57. 

    *** Original change description ***

Do less path string manipulation

to avoid windows-specific issues with patch application.

RELNOTES: N/A

***

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157080648
    @cushon @ronshapiro
    cushon authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    971f4de View commit details
    Browse the repository at this point in the history

  3. Support all annotations named 'GuardedBy' 

    including com.android.internal.annotations.GuardedBy.

RELNOTES: Support all annotations named 'GuardedBy'

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157140444
    @cushon @ronshapiro
    cushon authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    0c31402 View commit details
    Browse the repository at this point in the history

  4. Refactor duplicated code for finding super-method symbol to the Error… 

    … Prone core.

RELNOTES: n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157167781
    @panhania @ronshapiro
    panhania authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    88e39d0 View commit details
    Browse the repository at this point in the history

  5. Fix docs for NamedParameters 

    -------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157171839
    @plumpy @ronshapiro
    plumpy authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    c44ae4c View commit details
    Browse the repository at this point in the history

  6. Add java.util.Optional{Double,Int,Long} and java.util.UUID to the lis… 

    …t of well

known immutable classes.

RELNOTES: N/A

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157233479
    @nick-someone @ronshapiro
    nick-someone authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    75f7a2b View commit details
    Browse the repository at this point in the history

  7. Add a simplified checker to warn about inconsistent overloads. 

    RELNOTES: New checker to warn about inconsistent overloads.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157247805
    @panhania @ronshapiro
    panhania authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    6d4472d View commit details
    Browse the repository at this point in the history

  8. Fix ASTHelpers.hasAnnotation and Matchers.hasAnnotation to not consid… 

    …er declarations on references symbols.

"method(foo, bar)" should not match hasAnnotation("java.lang.Deprecated") even if the declaration of method is marked "@deprecated".

RELNOTES: hasAnnotation now only considers annotations on declaration trees.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157494127
    @ronshapiro
    bangert authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    a60e149 View commit details
    Browse the repository at this point in the history

  9. Add MultimapSubject.containsExactly() and MultimapSubject.comparingVa… 

    …luesUsing().containsExactly() to the should have even args check.

RELNOTES:

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157619475
    @Monnoroch @ronshapiro
    Monnoroch authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    3a79fd6 View commit details
    Browse the repository at this point in the history

  10. Bug Fix: BugCheckers should *only* be instantiated by ScannerSupplier… 

    …, which determines whether the default constructor exists, or whether an ErrorProneFlags constructor should be invoked instead.

Tricorder's ErrorProneFindingsJavacAnalyzer was directly calling BugChecker constructors rather than allowing a ScannerSupplier to construct them. This broke when ErrorProneFlags constructors were added to the Immutable checkers, and the no-args constructors removed.

This cl adds a getter to ErrorProneScanner for a scanner's instantiated BugCheckers, so no classes outside of Error Prone have to instantiate BugCheckers themselves.

RELNOTES: N/A

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157845791
    @epmjohnston @ronshapiro
    epmjohnston authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    3215c1c View commit details
    Browse the repository at this point in the history

  11. Add a second reverification pass to placeholder methods. 

    Placeholders are not generally allowed to reference variables that are bound to variables Refaster knows about but aren't passed into the placeholder method.  But this verification hadn't found when there were variables Refaster hadn't *yet* matched but would match after the placeholder.  So now, we just rerun that verification pass at the end of the match.

Bug discovered by sulku@ and mariasam@ :)

RELNOTES: fixes a subtle Refaster placeholder bug

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157862410
    @lowasser @ronshapiro
    lowasser authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    f2aaa2c View commit details
    Browse the repository at this point in the history

  12. Update documentation for PackageLocation to clarify that the package … 

    …path needs

to _end with_ the package.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=157864018
    @nick-someone @ronshapiro
    nick-someone authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    a9cdfd7 View commit details
    Browse the repository at this point in the history

  13. Swap IterableAndIterator{Positive,Negative}Cases, as they represent the 

    opposite than in other cases.

RELNOTES: n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=158062600
    @nick-someone @ronshapiro
    nick-someone authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    5f9a2ec View commit details
    Browse the repository at this point in the history

  14. Fix test breakage due to removal of GeneratedMessage.Builder#parseUnk… 

    …nownField

method.

This is just test code that represents generated proto code. The actual content
is not meaningful for our tests.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=158293382
    @ronshapiro
    eaftan authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    8e7e8b4 View commit details
    Browse the repository at this point in the history

  15. Updated NamedParameters to improve error message when comment doesn't… 

    … conform

to style and also to detect bad after-block comments. Change the suggestion to include spaces around the equals sign (the check is agnostic to spaces).

This change also removes @RequiresNamedParameters. We probably shouldn't be providing a new language feature which legitimizes an API design which should instead be refactored to improve usability.

RELNOTES: Change suggestion for NamedParameters to include spaces around the equals sign, improved errormessage and removed @RequiresNamedParameters

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=158570586
    @ronshapiro
    andrewrice authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    a9c4a64 View commit details
    Browse the repository at this point in the history

  16. Deprecate BugPattern.category, replacing it with a set of String tags… 

    …. These

tags can be used by tooling (including our Documentation generation) to group
BugCheckers into different buckets, and tag most of the existing warning-level
BugChecker instances.

RELNOTES: Deprecate BugPattern.category in favor of a collection of String
tags

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=158733828
    @nick-someone @ronshapiro
    nick-someone authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    92e5179 View commit details
    Browse the repository at this point in the history

  17. Edited ShortCircuitBoolean ErrorProne fix to only show one suggested … 

    …fix per

line

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=158880824
    @ronshapiro
    sulku authored and ronshapiro committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    215ee79 View commit details
    Browse the repository at this point in the history