-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moe sync #642
Moe sync #642
Commits on Jun 14, 2017
-
Fix false positives from FunctionalInterfaceClash.
If you have an inheritance chain that expands the visibility of an overridden method, the FunctionalInterfaceClash checker may consider consider those to be separate methods rather than overrides of the same method, causing a false positive. RELNOTES: None ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=157045905
Configuration menu - View commit details
-
Copy full SHA for 35b4442 - Browse repository at this point
Copy the full SHA 35b4442View commit details -
Automated rollback of 8a87d57.
*** Original change description *** Do less path string manipulation to avoid windows-specific issues with patch application. RELNOTES: N/A *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=157080648
Configuration menu - View commit details
-
Copy full SHA for 971f4de - Browse repository at this point
Copy the full SHA 971f4deView commit details -
Support all annotations named 'GuardedBy'
including com.android.internal.annotations.GuardedBy. RELNOTES: Support all annotations named 'GuardedBy' ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=157140444
Configuration menu - View commit details
-
Copy full SHA for 0c31402 - Browse repository at this point
Copy the full SHA 0c31402View commit details -
Refactor duplicated code for finding super-method symbol to the Error…
… Prone core. RELNOTES: n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=157167781
Configuration menu - View commit details
-
Copy full SHA for 88e39d0 - Browse repository at this point
Copy the full SHA 88e39d0View commit details -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=157171839
Configuration menu - View commit details
-
Copy full SHA for c44ae4c - Browse repository at this point
Copy the full SHA c44ae4cView commit details -
Add java.util.Optional{Double,Int,Long} and java.util.UUID to the lis…
…t of well known immutable classes. RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=157233479
Configuration menu - View commit details
-
Copy full SHA for 75f7a2b - Browse repository at this point
Copy the full SHA 75f7a2bView commit details -
Add a simplified checker to warn about inconsistent overloads.
RELNOTES: New checker to warn about inconsistent overloads. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=157247805
Configuration menu - View commit details
-
Copy full SHA for 6d4472d - Browse repository at this point
Copy the full SHA 6d4472dView commit details -
Fix ASTHelpers.hasAnnotation and Matchers.hasAnnotation to not consid…
…er declarations on references symbols. "method(foo, bar)" should not match hasAnnotation("java.lang.Deprecated") even if the declaration of method is marked "@deprecated". RELNOTES: hasAnnotation now only considers annotations on declaration trees. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=157494127
Configuration menu - View commit details
-
Copy full SHA for a60e149 - Browse repository at this point
Copy the full SHA a60e149View commit details -
Add MultimapSubject.containsExactly() and MultimapSubject.comparingVa…
…luesUsing().containsExactly() to the should have even args check. RELNOTES: ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=157619475
Configuration menu - View commit details
-
Copy full SHA for 3a79fd6 - Browse repository at this point
Copy the full SHA 3a79fd6View commit details -
Bug Fix: BugCheckers should *only* be instantiated by ScannerSupplier…
…, which determines whether the default constructor exists, or whether an ErrorProneFlags constructor should be invoked instead. Tricorder's ErrorProneFindingsJavacAnalyzer was directly calling BugChecker constructors rather than allowing a ScannerSupplier to construct them. This broke when ErrorProneFlags constructors were added to the Immutable checkers, and the no-args constructors removed. This cl adds a getter to ErrorProneScanner for a scanner's instantiated BugCheckers, so no classes outside of Error Prone have to instantiate BugCheckers themselves. RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=157845791
Configuration menu - View commit details
-
Copy full SHA for 3215c1c - Browse repository at this point
Copy the full SHA 3215c1cView commit details -
Add a second reverification pass to placeholder methods.
Placeholders are not generally allowed to reference variables that are bound to variables Refaster knows about but aren't passed into the placeholder method. But this verification hadn't found when there were variables Refaster hadn't *yet* matched but would match after the placeholder. So now, we just rerun that verification pass at the end of the match. Bug discovered by sulku@ and mariasam@ :) RELNOTES: fixes a subtle Refaster placeholder bug ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=157862410
Configuration menu - View commit details
-
Copy full SHA for f2aaa2c - Browse repository at this point
Copy the full SHA f2aaa2cView commit details -
Update documentation for PackageLocation to clarify that the package …
…path needs to _end with_ the package. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=157864018
Configuration menu - View commit details
-
Copy full SHA for a9cdfd7 - Browse repository at this point
Copy the full SHA a9cdfd7View commit details -
Swap IterableAndIterator{Positive,Negative}Cases, as they represent the
opposite than in other cases. RELNOTES: n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=158062600
Configuration menu - View commit details
-
Copy full SHA for 5f9a2ec - Browse repository at this point
Copy the full SHA 5f9a2ecView commit details -
Fix test breakage due to removal of GeneratedMessage.Builder#parseUnk…
…nownField method. This is just test code that represents generated proto code. The actual content is not meaningful for our tests. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=158293382
Configuration menu - View commit details
-
Copy full SHA for 8e7e8b4 - Browse repository at this point
Copy the full SHA 8e7e8b4View commit details -
Updated NamedParameters to improve error message when comment doesn't…
… conform to style and also to detect bad after-block comments. Change the suggestion to include spaces around the equals sign (the check is agnostic to spaces). This change also removes @RequiresNamedParameters. We probably shouldn't be providing a new language feature which legitimizes an API design which should instead be refactored to improve usability. RELNOTES: Change suggestion for NamedParameters to include spaces around the equals sign, improved errormessage and removed @RequiresNamedParameters ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=158570586
Configuration menu - View commit details
-
Copy full SHA for a9c4a64 - Browse repository at this point
Copy the full SHA a9c4a64View commit details -
Deprecate BugPattern.category, replacing it with a set of String tags…
…. These tags can be used by tooling (including our Documentation generation) to group BugCheckers into different buckets, and tag most of the existing warning-level BugChecker instances. RELNOTES: Deprecate BugPattern.category in favor of a collection of String tags ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=158733828
Configuration menu - View commit details
-
Copy full SHA for 92e5179 - Browse repository at this point
Copy the full SHA 92e5179View commit details -
Edited ShortCircuitBoolean ErrorProne fix to only show one suggested …
…fix per line ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=158880824
Configuration menu - View commit details
-
Copy full SHA for 215ee79 - Browse repository at this point
Copy the full SHA 215ee79View commit details