Replace public constructor on an abstract class with protected #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
bangarharshit
force-pushed
the
public-constructor
branch
from
698e400
to
d9f25a0
Compare
Stephan202
reviewed
Oct 16, 2017
| @BugPattern( | ||
| name = "PublicConstructorForAbstractClass", | ||
| summary = | ||
| "Constructor on an abstract class can be declared abstract as there is never a need it to be public", |
There was a problem hiding this comment.
s/declared abstract/declared protected/s/need it/need for it/
| testHelper.addInputLines( | ||
| "in/Test.java", | ||
| "public abstract class Test {", | ||
| " public Test() { }", |
There was a problem hiding this comment.
Maybe use two-space indentation in the test code?
bangarharshit
force-pushed
the
public-constructor
branch
from
d9f25a0
to
7eb9fd8
Compare
|
Ping for review. Already addressed comments by Stephen |
Merged
cgdecker
pushed a commit
that referenced
this pull request
May 20, 2020
protected Fixes #776 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=312188474
cgdecker
pushed a commit
that referenced
this pull request
May 20, 2020
protected Fixes #776 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=312188474
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - #134. Added a suggestion to modify the modifier of constructor in an abstract class to protected. The constructor in abstract class doesn't need to be public since it can't be instantiated and it leads to better code semantics.