Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -XepDisableAllWarnings flag #785

Closed
wants to merge 3 commits into from

Conversation

msridhar
Copy link
Contributor

This flag turns off all WARNING-level checks, while leaving on those at ERROR level. This is useful for those who want to compile with -Werror but don't want any EP WARNING-level issue to block the build. Individual WARNING level checks can still be set to ERROR level as desired.

This enables turning off all WARNING-level checks, while leaving on those at ERROR level.
@thalescm
Copy link

thalescm commented May 6, 2019

Is there any chance this might ever be merged to this repo?

@danielkaneider
Copy link

Any chance to rebase this PR and get it merged?

@msridhar
Copy link
Contributor Author

I'm happy to do the rebase work if there is interest in merging this PR

@msridhar
Copy link
Contributor Author

Let me pitch another use case for this flag. For an existing project trying to adopt Error Prone, the initial number of errors + warnings can be overwhelming. While the warnings will not block the build, they do introduce a lot of noise in the build logs, which could turn off new users. (I just ran into this with a student trying to introduce Error Prone to a project today.) The proposed flag could give users a more incremental way to adopt Error Prone (first fix errors, then warnings), or a less noisy way if they never intend to fix the warnings.

Again, I am happy to rebase and update the PR if there is interest in landing it. And if there is no interest, then we can close it out.

/cc @eaftan

@cushon cushon self-assigned this May 15, 2020
@kluever kluever mentioned this pull request May 17, 2020
kluever pushed a commit that referenced this pull request May 17, 2020
This flag turns off all WARNING-level checks, while leaving on those at ERROR level. This is useful for those who want to compile with -Werror but don't want any EP WARNING-level issue to block the build. Individual WARNING level checks can still be set to ERROR level as desired.

Fixes #785

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=311831028
kluever pushed a commit that referenced this pull request May 17, 2020
This flag turns off all WARNING-level checks, while leaving on those at ERROR level. This is useful for those who want to compile with -Werror but don't want any EP WARNING-level issue to block the build. Individual WARNING level checks can still be set to ERROR level as desired.

Fixes #785

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=311831028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants