Prevent ConstructorLeaksThis false positive on constructor reference
#789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
force-pushed
the
bugfix/issue-655
branch
from
495b0be
to
fd2c185
Compare
|
Maybe somebody from the Error Prone team can find some time to review this PR? It doesn't seem too controversial :D. |
Merged
ronshapiro
pushed a commit
that referenced
this pull request
Feb 12, 2018
reference Fixes #789 RELNOTES: Fixed false positive in ConstructorLeaksThis ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=185219776
cushon
pushed a commit
that referenced
this pull request
Feb 12, 2018
reference Fixes #789 RELNOTES: Fixed false positive in ConstructorLeaksThis ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=185219776
|
Sorry for the delay, and thank you for the contribution! |
|
This PR will be of great help in junit-team/junit5#1266. :) |
sebright
added a commit
to sebright/opencensus-java
that referenced
this pull request
Jun 13, 2018
This commit contains several other changes as part of the upgrade: - Use -XepAllDisabledChecksAsWarnings to enable all available warnings so that we don't need to enable each warning explicitly. - Remove explicit suppression of warnings in generated code, since -XepDisableWarningsInGeneratedCode is now sufficient to suppress all warnings in AutoValue and Protocol Buffer generated classes. - Remove a suppression of "ConstructorLeaksThis", since google/error-prone#789 was fixed. - Fix a few occurrences of "FieldCanBeFinal".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #655.