gltfio: add createInstance() to AssetLoader. #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainguy
approved these changes
Oct 28, 2020
| * gradually add them to the scene as needed. Instances can also be "recycled" by removing and | ||
| * re-adding them to the scene. | ||
| * | ||
| * NOTE: destroyInstance() does not exist because gltfio favors flat arrays for storage of |
There was a problem hiding this comment.
Would it be that slow? Those arrays won't be big.
There was a problem hiding this comment.
Not super slow, but in some cases, the number of entities in an instance can be large. Also the texture dependency graph has to be re-checked in case a large texture are still being loaded during instance creation.
bejado
approved these changes
Oct 28, 2020
android/gltfio-android/src/main/java/com/google/android/filament/gltfio/AssetLoader.java
Show resolved
Hide resolved
Note that this API is on the loader rather than the asset. This is because the loader knows how to create Filament entities by traversing a cgltf node hierarchy. Animation on dynamically added instances is not yet supported. We did not add destroyInstance() because gltfio favors flat arrays for long term storage of entity lists and instance lists, which would be slow to shift. We also wish to discourage create/destroy churn since it is more efficient to pre-allocate instances and selectively add them into the scene. Fixes #3137.
prideout
force-pushed
the
pr/dynamic_instances
branch
from
3bc4f4c to
99b1da6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this API is on the loader rather than the asset. This is
because the loader knows how to create Filament entities by traversing
a cgltf node hierarchy.
We did not add destroyInstance() because gltfio favors flat arrays for
long term storage of entity lists and instance lists, which would be
slow to shift. We also wish to discourage create/destroy churn since it
is more efficient to pre-allocate instances and selectively add them
into the scene.
Fixes #3137.