add check for root_type specified for json schema generation #5622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! As recommended here I've added simple check to avoid segfault. In my opinion this solution currently misses user friendly error message, but I dont see any example near this place in codebase for propagating error message. Can you advise me how to properly do this? Also I'll be glad to add test for change I made, so the question is what is the best place for such test? Can I simply add fbs file without root_type and test return code of flatc in generate_code.sh or something else?
Also recommendations for PR says:
Firstly script is renamed to just
clang-format.sh
and after I launched it there are format related changes to code that is not related to my changes. So definetly this check should be in CI to protect the health of the codebase.