-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C#]SpanT is available in .Net Standard 2.0. #6137
[C#]SpanT is available in .Net Standard 2.0. #6137
Conversation
Thanks, this fixed it! |
To my knowledge, The current .NET Core project, as-is, doesn't build successfully when targeting .NET Standard 2.0 with Perhaps @anassinator can help clarify? |
@ConanChenTookMyName We do use the |
@anassinator Are you using a custom/modified project file to include the package reference? |
@ConanChenTookMyName Yes, we have our own separate build system. |
@ConanChenTookMyName I also decided that supporting .Net Standard 2.0 was unnecessary because the project lacked the necessary references and was not as fast as it should be. But there were potential users like him, and perhaps he was in trouble. And he's probably not the only one in trouble. The reinstatement of limited support for .NetStandard 2.0 is not detrimental to current performance. I also think it is in line with @dbaileychess desire to "widely available as possible". I also had some problems with my commits. This is because in some environments (e.g. Visual Studio), the code is compiled in parallel with 2.1, so I think there were cases where 2.1 compiling didn't even go through due to 2.0 errors. This commit takes that into account, and prints a warning rather than an error for the wrong flag combination. |
Restored the use of SpanT in .NetStandard 2.0 as pointed out in the following link.
#6073 (comment)
A warning is added for compiling if the flags are inconsistent.