Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Optional enum when it is null #6835

Merged
merged 6 commits into from
Sep 10, 2021

Conversation

REASY
Copy link
Contributor

@REASY REASY commented Sep 6, 2021

This PR is fixing #6830

@google-cla
Copy link

google-cla bot commented Sep 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@github-actions github-actions bot added c# c++ codegen Involving generating code from schema labels Sep 6, 2021
@REASY
Copy link
Contributor Author

REASY commented Sep 6, 2021

@googlebot I signed it!

@REASY
Copy link
Contributor Author

REASY commented Sep 6, 2021

Should I bump up the minor version

#define FLATBUFFERS_VERSION_MINOR 0
?

@CasperN
Copy link
Collaborator

CasperN commented Sep 7, 2021

Should I bump up the minor version?

Seems reasonable to me, we just started being strict with semver. That said, I'm not familiar with the update process, perhaps there may be more places to touch? @aardappel would know

@REASY
Copy link
Contributor Author

REASY commented Sep 8, 2021

@CasperN @aardappel I git blamed https://github.com/google/flatbuffers/blob/master/include/flatbuffers/base.h#L147 to see whether FLATBUFFERS_VERSION_REVISION was ever changed, didn't find anything. According to SemVer 2.0 one should increment PATCH version when you make backwards compatible bug fixes. Am I right that FLATBUFFERS_VERSION_REVISION is equivalent to the PATCH version and I should increment that one instead of FLATBUFFERS_VERSION_MINOR?

@CasperN
Copy link
Collaborator

CasperN commented Sep 8, 2021

Hmm, well, i think there's been a breaking change since 2.0.0 somewhere, so its not important to bump the semver. We'll just advance to 3.0.0 at the next release

@CasperN
Copy link
Collaborator

CasperN commented Sep 8, 2021

I'll squash and merge once CI passes. Thank you for contributing!

@CasperN CasperN merged commit 47d35f1 into google:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c# c++ codegen Involving generating code from schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants