-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix: Optional enum when it is null #6835
BugFix: Optional enum when it is null #6835
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Should I bump up the minor version flatbuffers/include/flatbuffers/base.h Line 146 in 550d2f9
|
Seems reasonable to me, we just started being strict with semver. That said, I'm not familiar with the update process, perhaps there may be more places to touch? @aardappel would know |
@CasperN @aardappel I git blamed https://github.com/google/flatbuffers/blob/master/include/flatbuffers/base.h#L147 to see whether |
Hmm, well, i think there's been a breaking change since 2.0.0 somewhere, so its not important to bump the semver. We'll just advance to 3.0.0 at the next release |
I'll squash and merge once CI passes. Thank you for contributing! |
This PR is fixing #6830