Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code gen flexbuffer verifier #7207

Merged
merged 4 commits into from
Apr 5, 2022
Merged

Conversation

dbaileychess
Copy link
Collaborator

Fixes: #7134

This adds code gen for the verify nested flatbuffers.

@github-actions github-actions bot added c++ codegen Involving generating code from schema labels Apr 1, 2022
@dbaileychess
Copy link
Collaborator Author

@aardappel Is this what you were thinking?

include/flatbuffers/flexbuffers.h Outdated Show resolved Hide resolved
tests/cpp17/generated_cpp17/monster_test_generated.h Outdated Show resolved Hide resolved
@dbaileychess dbaileychess force-pushed the master branch 2 times, most recently from 477a0aa to 02c7140 Compare April 4, 2022 22:47
Copy link
Collaborator

@aardappel aardappel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm besides these 2:

include/flatbuffers/flex_flat_util.h Show resolved Hide resolved
include/flatbuffers/flexbuffers.h Outdated Show resolved Hide resolved
@dbaileychess dbaileychess merged commit f083b33 into google:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ codegen Involving generating code from schema
Projects
None yet
2 participants