Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotated Binaries emit field names instead of type names #7735

Closed
wants to merge 1 commit into from

Conversation

dbaileychess
Copy link
Collaborator

@dbaileychess dbaileychess commented Dec 22, 2022

Fixes: #7714

Instead of using the Object name for structs, use the referring field name to label.

@github-actions github-actions bot added c++ codegen Involving generating code from schema labels Dec 22, 2022
@enum-class
Copy link
Contributor

enum-class commented Dec 23, 2022

I think struct name is also helpful, maybe something like this

+0x00D3 | 05 ...         | struct field `pains.ParamSet.hp` (UByte)

@bWFpbA
Copy link

bWFpbA commented Dec 23, 2022

I think struct name is also helpful, maybe something like this

+0x00D3 | 05 ...         | struct field `pains.ParamSet.hp` (UByte)

While having the struct name would be helpful, I don't think it's entirely necessary since annotation requires that you have some form of schema (text, binary) which you can use as a reference.
However, if you do want to include the struct name, how about this?

+0x00D3 | 05 ...         | struct field `pains.hp` (ParamSet.UByte)

@dbaileychess
Copy link
Collaborator Author

Thanks, I will get back to this shortly

@enum-class
Copy link
Contributor

What happened to this p,r, ?

@dbaileychess
Copy link
Collaborator Author

I don't use git for my day job and somehow butchered my repo while pushing another PR. I will resurrect this in a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatc annotation provides struct name and not field name
3 participants