Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Enable using struct and array of struct as key #7741

Merged
merged 23 commits into from
Jan 25, 2023
Merged

[C++] Enable using struct and array of struct as key #7741

merged 23 commits into from
Jan 25, 2023

Conversation

sunwen18
Copy link
Contributor

For #7558
Enable using struct, array of struct as key

  • Updated parser
  • Updated idl_gen_cpp.cpp
  • Added new unit tests

@github-actions github-actions bot added c++ codegen Involving generating code from schema labels Dec 25, 2022
@sunwen18 sunwen18 changed the title [CPP] Enable using struct and array of struct as key [C++] Enable using struct and array of struct as key Dec 25, 2022
@sunwen18 sunwen18 marked this pull request as draft December 25, 2022 20:56
@github-actions github-actions bot added the CI Continuous Integration label Dec 26, 2022
@sunwen18 sunwen18 marked this pull request as ready for review December 26, 2022 06:17
@github-actions github-actions bot removed the CI Continuous Integration label Dec 28, 2022
enum-class
enum-class reviewed Jan 4, 2023
View reviewed changes
tests/key_field/key_field_sample_generated.h Outdated Show resolved Hide resolved
tests/key_field/key_field_sample_generated.h Outdated Show resolved Hide resolved
tests/key_field/key_field_sample_generated.h Outdated Show resolved Hide resolved
tests/key_field/key_field_sample_generated.h Outdated Show resolved Hide resolved
tests/key_field/key_field_sample_generated.h Show resolved Hide resolved
dbaileychess
dbaileychess reviewed Jan 4, 2023
View reviewed changes
tests/key_field/key_field_sample_generated.h Outdated Show resolved Hide resolved
tests/key_field/key_field_sample_generated.h Outdated Show resolved Hide resolved
tests/key_field/key_field_sample_generated.h Outdated Show resolved Hide resolved
@sunwen18 sunwen18 requested review from enum-class and dbaileychess and removed request for dbaileychess and enum-class January 20, 2023 07:45
@dbaileychess dbaileychess merged commit 802a3a0 into google:master Jan 25, 2023
@sunwen18 sunwen18 mentioned this pull request Jan 25, 2023
Merged
tungmeoo
tungmeoo reviewed May 8, 2023
View reviewed changes
Copy link

@tungmeoo tungmeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

submit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tungmeoo tungmeoo tungmeoo left review comments

@enum-class enum-class enum-class left review comments

@dbaileychess dbaileychess dbaileychess approved these changes

Assignees
No one assigned
Labels
c++ codegen Involving generating code from schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunwen18 @dbaileychess @tungmeoo @enum-class