Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMAKE_CURRENT_SOURCE_DIR in benchmark cpp path #7781

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Use CMAKE_CURRENT_SOURCE_DIR in benchmark cpp path #7781

merged 2 commits into from
Jan 19, 2023

Conversation

liuq19
Copy link
Contributor

@liuq19 liuq19 commented Jan 12, 2023

Use CMAKE_CURRENT_SOURCE_DIR in the cpp benchmark, so that the benchmark CMake can work in the different build paths.

This fixed #7652.

@google-cla
Copy link

google-cla bot commented Jan 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dbaileychess dbaileychess enabled auto-merge (squash) January 19, 2023 07:43
@dbaileychess dbaileychess merged commit 991b39e into google:master Jan 19, 2023
@liuq19 liuq19 deleted the fix/benchmark_cmake branch January 19, 2023 12:12
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
Co-authored-by: Derek Bailey <derekbailey@google.com>
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
Co-authored-by: Derek Bailey <derekbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CUSTOMBUILD error on flatbenchmark
2 participants