Refactor languages to use CodeGenerator interface. #7797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move code to its own header file to be included in flatc_main.cpp - Refactor code to use CodeGenerator interface for all languages
github-actions
bot
added
c#
c++
codegen
…d extern declaration
le-michael
reviewed
Jan 23, 2023
dbaileychess
previously approved these changes
Jan 24, 2023
|
The CodeQL pipeline is also broken, and it seems to use cmake to build it: https://github.com/google/flatbuffers/blob/master/.github/workflows/codeql.yml#L67 |
enum-class
reviewed
Jan 25, 2023
enum-class
reviewed
Jan 25, 2023
Local run doesn't fail. I tried with both gcc and clang. Wonder what was the issue. |
dbaileychess
approved these changes
Jan 25, 2023
|
Thanks! |
dbaileychess
added
the
release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor all languages to use
CodeGeneratorinterface.Move
externdeclarations into their own header files and include the functions inflatc_main.cpp.Register all languages code generator except
Lua,Nim, andtext.Run sh scripts/clang-format-git.sh
Run ./scripts/generate_code.py