Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and fix TypeScript compilation output #7815

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

bjornharrtell
Copy link
Collaborator

ref #7814

@bjornharrtell
Copy link
Collaborator Author

I've verified the fix by producing a local npm package and using in depended project that previously failed in bundling step.

@dbaileychess this fixes a fairly serious regression for users of the npm package so I'd recommend a new release with this fix in as soon as possible.

@dbaileychess dbaileychess merged commit 85aee1f into google:master Feb 6, 2023
@dbaileychess dbaileychess added the release-notes The PR should be highlighted in the release notes of the next release it is in. label Feb 6, 2023
@bjornharrtell bjornharrtell deleted the fix-tsc-target branch February 6, 2023 21:48
dbaileychess pushed a commit that referenced this pull request Mar 15, 2023
* Simplify and fix TypeScript compilation output

* Revert deps upgrade
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
* Simplify and fix TypeScript compilation output

* Revert deps upgrade
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
* Simplify and fix TypeScript compilation output

* Revert deps upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
json python release-notes The PR should be highlighted in the release notes of the next release it is in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants