TS/JS: Export object based classes on entry #7822
Conversation
Along with the non object ones, for consistency. This is a regression
introduced recently.
Before:
`export { UpdateSettingsRequest } from './worker/update-settings-request.js';`
Now:
`export { UpdateSettingsRequest, UpdateSettingsRequestT } from './worker/update-settings-request.js';`
github-actions
bot
added
c++
codegen
This reverts commit 6c10e82. Until the following regression fix is implemented: google/flatbuffers#7822
|
I'll fix Generated Code checks. |
Enums are not elegible.
|
CodeQL action failing. I've run locally and I don't get any error. I can't re-rerun the action, probably due to permissions in the repo, in case this was due to some temporal error. @dbaileychess, what do you think about this PR? Object based classes were before exported along with non object ones. I consider their absence a regression, and good to have both exported at the same level. |
|
Sorry for forgetting about the object API when reworking the export logic. The fix looks good to me, thanks. |
|
Hi, Any chance this PR can be reviewed? |
|
Please, can this PR have few minutes for review? It fixes a regression which makes otherwise add a great amount of import statements in user code. @bjornharrtell confirms the issue and considers the PR OK. I'd like to avoid changing my code so much due to the issue that is fixed here. |
|
Ping @dbaileychess |
* TS/JS: Export object based classes on entry
Along with the non object ones, for consistency. This is a regression
introduced recently.
Before:
`export { UpdateSettingsRequest } from './worker/update-settings-request.js';`
Now:
`export { UpdateSettingsRequest, UpdateSettingsRequestT } from './worker/update-settings-request.js';`
* only export object based classes for structs
Enums are not elegible.
---------
Co-authored-by: Björn Harrtell <bjornharrtell@users.noreply.github.com>
Co-authored-by: Derek Bailey <derekbailey@google.com>
Along with the non object ones, for consistency. This is a regression introduced recently.
Before:
export { UpdateSettingsRequest } from './worker/update-settings-request.js';Now:
export { UpdateSettingsRequest, UpdateSettingsRequestT } from './worker/update-settings-request.js';