Fix setup trigger issue under sharing and transforms. #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a subtle bug in the case of using a shared module that defined a setup() method that was called first at one location under a transform (like remat or jit) and at another location without the transform. In the latter case the "outside" instance of the submodule had had a "shallow" _try_setup call pre-transform and was then marked as having had setup called, but the setup method had not in fact been called. This requires a one-line logic fix in _try_setup().
Codecov Report
@@ Coverage Diff @@
## main #3153 +/- ##
=======================================
Coverage 82.12% 82.12%
=======================================
Files 55 55
Lines 6063 6064 +1
=======================================
+ Hits 4979 4980 +1
Misses 1084 1084
|
cgarciae
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a subtle bug in the case of using a shared module that defined a setup() method that was called first at one location under a transform (like remat or jit) and at another location without the transform.
In the latter case the "outside" instance of the submodule had had a "shallow" _try_setup call pre-transform and was then marked as having had setup called, but the setup method had not in fact been called. This requires a one-line logic fix in _try_setup().