Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NNX/Linen API consistency test for Linear/Dense layer #3509

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

Micky774
Copy link
Collaborator

@Micky774 Micky774 commented Nov 27, 2023

What does this PR do?

Added NNX/Linen API consistency test for Linear/Dense layer

Fixes # (issue)

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).
  • This change is discussed in a Github issue/
    discussion (please add a
    link).
  • The documentation and docstrings adhere to the
    documentation guidelines.
  • This change includes necessary high-coverage tests.
    (No quality testing = no merge!)

@Micky774
Copy link
Collaborator Author

cc: @cgarciae

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a572f6a) 53.80% compared to head (3024a14) 53.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3509      +/-   ##
==========================================
+ Coverage   53.80%   53.93%   +0.12%     
==========================================
  Files          98       98              
  Lines       11524    11546      +22     
==========================================
+ Hits         6201     6227      +26     
+ Misses       5323     5319       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@copybara-service copybara-service bot merged commit 68333d4 into google:main Nov 29, 2023
19 checks passed
@Micky774 Micky774 deleted the nnx_linear_api_tests branch November 30, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants