Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NNX/Linen API consistency test for Conv layer #3511

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

Micky774
Copy link
Collaborator

@Micky774 Micky774 commented Nov 28, 2023

What does this PR do?

Added NNX/Linen API consistency test for Linear/Dense layer

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).
  • This change is discussed in a Github issue/
    discussion (please add a
    link).
  • The documentation and docstrings adhere to the
    documentation guidelines.
  • This change includes necessary high-coverage tests.
    (No quality testing = no merge!)

@Micky774
Copy link
Collaborator Author

@cgarciae note that this new test alone takes about 45s on my machine (w/ GPU) to run. It covers all the commonly used, public API but is pretty slow. Let me know if you think we need to tweak the coverage.

@copybara-service copybara-service bot merged commit cdc7feb into google:main Nov 29, 2023
19 checks passed
@Micky774 Micky774 deleted the nnx_conv_api_tests branch November 30, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants