Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash in dataclasses with no-init params #3514

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

NeilGirdhar
Copy link
Contributor

No description provided.

@NeilGirdhar
Copy link
Contributor Author

@cgarciae

@NeilGirdhar NeilGirdhar reopened this Nov 28, 2023
@cgarciae
Copy link
Collaborator

Thanks @NeilGirdhar ! Can you fix the pre-commit issue?

@Micky774
Copy link
Collaborator

the pre-commit issue should be resolved w/ new changes in the upstream -- just need to merge/rebase

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a572f6a) 53.80% compared to head (2ef8783) 53.80%.

Files Patch % Lines
flax/experimental/nnx/nnx/module.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3514      +/-   ##
==========================================
- Coverage   53.80%   53.80%   -0.01%     
==========================================
  Files          98       98              
  Lines       11524    11526       +2     
==========================================
+ Hits         6201     6202       +1     
- Misses       5323     5324       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgarciae
Copy link
Collaborator

Thanks @NeilGirdhar !

@copybara-service copybara-service bot merged commit ca9606b into google:main Nov 29, 2023
19 checks passed
@NeilGirdhar NeilGirdhar deleted the initbug branch November 29, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants