Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-factored nnx initializers #3555

Merged
merged 1 commit into from
Dec 19, 2023
Merged

re-factored nnx initializers #3555

merged 1 commit into from
Dec 19, 2023

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Dec 14, 2023 •
edited
Loading

Re-naming zeros and ones initializers to zeros_init and ones_init, so that it's consistent with Linen initializers and users won't be confused between NNX zeros/ones and JAX zeros/ones since they have different function signatures.

See also #2002 and #2790.

@chiamp chiamp self-assigned this Dec 14, 2023
@chiamp chiamp requested a review from cgarciae December 14, 2023 23:52
@cgarciae
Copy link
Collaborator

I believe we only used zeros/ones_init as a work around for historical reason. Maybe we should make this right in NNX and just use zeros and ones directly?

cgarciae
cgarciae approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@cgarciae cgarciae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks goods!

@copybara-service copybara-service bot merged commit dad384c into google:main Dec 19, 2023
16 checks passed
@chiamp chiamp deleted the nnx_initializers branch December 19, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgarciae cgarciae cgarciae approved these changes

Assignees

@chiamp chiamp

Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chiamp @cgarciae