-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added multiheadattention alias #3572
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
reviewed
Dec 20, 2023
chiamp
force-pushed
the
attention_subclass
branch
from
December 20, 2023 18:40
911c84f
to
74e165e
Compare
cgarciae
approved these changes
Jan 8, 2024
chiamp
force-pushed
the
attention_subclass
branch
from
January 10, 2024 00:17
74e165e
to
09f6ea4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3572 +/- ##
=======================================
Coverage 56.72% 56.72%
=======================================
Files 100 100
Lines 12008 12009 +1
=======================================
+ Hits 6811 6812 +1
Misses 5197 5197 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #3552.
Added
MultiHeadAttention
alias.Also added
sow_weights
arg toSelfAttention
, see #3529.