Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added multiheadattention alias #3572

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Dec 18, 2023

Continuing from #3552.

Added MultiHeadAttention alias.

Also added sow_weights arg to SelfAttention, see #3529.

flax/linen/attention.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fae3a30) 56.72% compared to head (09f6ea4) 56.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3572   +/-   ##
=======================================
  Coverage   56.72%   56.72%           
=======================================
  Files         100      100           
  Lines       12008    12009    +1     
=======================================
+ Hits         6811     6812    +1     
  Misses       5197     5197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@copybara-service copybara-service bot merged commit 90e6b60 into google:main Jan 10, 2024
18 of 19 checks passed
copybara-service bot pushed a commit that referenced this pull request Jan 11, 2024
…is PR re-adds the attention changes again and fixes internal tests

PiperOrigin-RevId: 597276997
copybara-service bot pushed a commit that referenced this pull request Jan 11, 2024
…is PR re-adds the attention changes again and fixes internal tests

PiperOrigin-RevId: 597276997
copybara-service bot pushed a commit that referenced this pull request Jan 12, 2024
…is PR re-adds the attention changes again and fixes internal tests

PiperOrigin-RevId: 597276997
copybara-service bot pushed a commit that referenced this pull request Jan 12, 2024
…is PR re-adds the attention changes again and fixes internal tests

PiperOrigin-RevId: 597881774
@chiamp chiamp deleted the attention_subclass branch March 16, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants