added nnx attention equivalence test #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3687 +/- ##
==========================================
+ Coverage 56.13% 58.27% +2.13%
==========================================
Files 102 102
Lines 12220 12248 +28
==========================================
+ Hits 6860 7137 +277
+ Misses 5360 5111 -249 ☔ View full report in Codecov by Sentry. |
chiamp
force-pushed
the
nnx_attention
branch
from
5dc8b4e
to
a948cb5
Compare
cgarciae
approved these changes
Feb 10, 2024
chiamp
force-pushed
the
nnx_attention
branch
from
a948cb5
to
6956a2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added nnx attention equivalence test.
Also passed in user-passed
dtypeandparam_dtypeargs into the layer norm layers for both NNX and Linen.